Add cf program integration#185
Conversation
Implements the add-cf-program spec change by converting the hardcoded zsh alias into a standalone Nix program module with proper dependency management. Changes: - Create modules/programs/cf/ with shell script and Nix derivation - Enable cf program in engineer feature for both NixOS and Darwin - Replace inline alias in .zshrc with wrapper to nix-managed cf command - Update tasks.md to reflect completed implementation The cf program uses fd and fzf for interactive directory selection with graceful cancellation support and cross-platform compatibility.
WalkthroughAdds a Nix-packaged Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Z as zsh (interactive)
participant CF as cf (nix-installed)
participant FD as fd
participant FZF as fzf
Z->>CF: run `command cf` (alias: cd $(command cf))
CF->>FD: enumerate dirs (hidden allowed, exclude .git)
FD-->>CF: directory list
CF->>FZF: show list with `ls` preview
FZF-->>CF: selected path or cancel
alt selection made
CF-->>Z: echo selected path
Z->>Z: cd into echoed path
else cancelled
CF-->>Z: (no output)
Z->>Z: remain in current directory
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
modules/programs/cf/cf.sh (1)
1-1: Verify shebang redundancy with writeShellApplication.The shebang line is typically redundant when using
writeShellApplication, as it adds its own shebang and preamble. While this usually doesn't cause issues, consider removing it for cleaner integration with the Nix wrapper.Apply this diff if you want to remove the redundant shebang:
-#!/usr/bin/env bash # cf - Fuzzy directory finder
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.zshrc(1 hunks)modules/features/engineer.nix(2 hunks)modules/programs/cf/cf.sh(1 hunks)modules/programs/cf/default.nix(1 hunks)spectr/changes/add-cf-program/tasks.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Validate Templates (linux-x86_64)
- GitHub Check: Validate Templates (macos-aarch64)
- GitHub Check: Build (linux-x86_64)
- GitHub Check: Build (macos-aarch64)
🔇 Additional comments (8)
spectr/changes/add-cf-program/tasks.md (1)
1-24: LGTM! Task tracking is complete and consistent.The checklist comprehensively covers the implementation, testing, and integration steps, and all items are appropriately marked as complete in alignment with the actual code changes.
modules/programs/cf/cf.sh (1)
13-26: LGTM! Robust implementation with proper error handling.The script correctly:
- Uses strict mode (
set -euo pipefail) for error prevention- Handles cancellation gracefully with
|| true- Provides sensible defaults for the starting directory
- Validates output before echoing
The fd/fzf integration is well-structured and the preview command will work correctly with fzf's placeholder substitution.
.zshrc (1)
49-50: LGTM! Correct delegation to the nix-managed cf binary.The use of
command cfproperly bypasses alias resolution to call the external program, preventing infinite recursion. The updated comment accurately describes the new behavior.modules/features/engineer.nix (2)
39-39: LGTM! Correct feature flag addition for NixOS.The cf program is properly enabled for NixOS configurations with appropriate alphabetical placement among other program enables.
207-207: LGTM! Correct feature flag addition for Darwin.The cf program is properly enabled for Darwin/macOS configurations with appropriate alphabetical placement.
modules/programs/cf/default.nix (3)
1-41: LGTM! Excellent comprehensive documentation.The module documentation is thorough and well-structured, covering all essential aspects including description, platform support, features, implementation details, usage examples, and configuration. This follows best practices for Nix module documentation.
50-58: LGTM! Correct writeShellApplication configuration.The program definition properly:
- Names the binary "cf"
- Reads the script content from ./cf.sh
- Wraps the necessary runtime dependencies (fd, fzf, coreutils)
This follows the standard Nix pattern for creating shell applications with managed dependencies.
60-72: LGTM! Standard module structure with proper cross-platform support.The module correctly:
- Uses the delib.module pattern with appropriate naming
- Defaults to disabled (requiring explicit enablement)
- Installs the program as a system package on both NixOS and Darwin when enabled
- Follows the established pattern consistent with other program modules in the codebase
connerohnesorge
changed the title
connerohnesorge
deleted the
claude/add-cf-program-01VdXAvAXKbgnDMtN3hCF3vu
branch
2 participants
Implements the add-cf-program spec change by converting the hardcoded zsh alias into a standalone Nix program module with proper dependency management.
Changes:
The cf program uses fd and fzf for interactive directory selection with graceful cancellation support and cross-platform compatibility.
Summary by CodeRabbit
New Features
cfutility for fuzzy directory navigation with live preview.Chores
cfprogram across relevant system configurations (NixOS and macOS).cfcommand for directory switching.✏️ Tip: You can customize this high-level summary in your review settings.